Re: Another idea for simplifying locking in kernel/module.c

[Adam J. Richter]

On Thu, 09 Jan 2003, Max Krasnyansky wrote:
>At 12:53 AM 1/7/2003 -0800, Adam J. Richter wrote:
>>I wrote:
>>>        Here is a way to replace all of the specialized "stop CPU"
>>>locking code in kernel/module.c with an rw_semaphore by using
>>>down_read_trylock in try_module_get() and down_write when beginning to
>>>unload the module.
>>>
>>>        The following UNTESTED patch, a net deletion of 136 lines,
>>
>>        I am running that patch now on two computers.  It seems to
>>be OK.
>>
>>        Rusty, I'd be interested in knowing what you think of the
>>patch (likewise for other lkml readers).

>We have to be able to call try_module_get() from interrupt context.

	Where?  Why?  Please show me one or more examples.

Adam J. Richter     __     ______________   575 Oroville Road
[e-mail]     \ /                  Milpitas, California 95035
[phone]         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."