Re: [PATCH] Set TIF_IRET in more places

Luca Barbieri (ldb@ldb.ods.org)
Mon, 6 Jan 2003 19:17:37 +0100


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-10599-1041877835-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

I've looked again at it and it is actually less problematic that I
first thought but I still see the following two cases:

1. vfork seems to not set any TIF_ flags so a ptracer setting regs
while a vforking task is stopped in ptrace_notify called from vfork
would result in clobbered %ecx and %edx.

2. A ptracer could use %ecx or %edx to pass information to signal
handlers and this would not work with the current [rt_]sigsuspend.

These only need setting TIF_IRET on ptrace setregs though.

There is also the very small advantage of being able to hardcode
SYSENTER_RETURN as the return eip for sysexit if TIF_IRET is set in
all the 3 places.

--=_courier-10599-1041877835-0001-2
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+GchAdjkty3ft5+cRAmlmAJ0dw/LnDXDwg+M8Luq8gjX4adJpFQCfdUfl
W+iIlCFMHMiTihw+cuGPxCI=
=DMN9
-----END PGP SIGNATURE-----

--=_courier-10599-1041877835-0001-2--