Re: [PATCH] Overzealous permenant mark removed

[Rusty Russell]

In message <[e-mail]> you wri
te:
> And if somebody wants to create an un-unloadable driver, he should just 
> increment the module count and be done with it. No magic rules (maybe you 
> can make /proc/modules print out "<permanent>" if the count is over some 
> number, and then people who want permanent modules just initialize the 
> count past that).

OTOH, your approach left us with stuff that wasn't modular at all
(like IPv4) because people felt it was somehow "wrong" to make it
non-unloadable.

I guess it depends on numbers.  If we see lots of drivers which
initialize things and don't really need to clean up, you're right.

If we see far more "I didn't implement unloading" drivers, it's
easiest to do the safe thing: require the author DO SOMETHING to make
the module unloadable, not vice versa.

But the change is trivial,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.