Re: [PATCH] Overzealous permenant mark removed

Dave Jones (davej@codemonkey.org.uk)
Mon, 30 Dec 2002 11:40:43 +0000


On Fri, Dec 27, 2002 at 07:44:41PM +1100, Rusty Russell wrote:

> Name: Modules without init functions don't need exit functions
> D: If modules don't use module_exit(), they cannot be unloaded. This
> D: safety mechanism should not apply for modules which don't use
> D: module_init() (implying they have nothing to clean up anyway).

Just a heads up, as this bit me with agpgart which had a module_init()
but no module_exit() and then found itself un-unloadable[1].
I don't know if agpgart found itself in the unique position of doing
this (It only really used its _init function to clear some vars,
and printk a banner), but its something to keep an eye out for.

I fixed it by adding a null _exit function, (which later did a
sanity check just for good measure).

Dave

[1] Coo, a new silly word.

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/