Re: [PATCH] more deprectation bits

Christoph Hellwig (hch@lst.de)
Sun, 29 Dec 2002 22:47:13 +0100


On Sun, Dec 29, 2002 at 01:38:51PM -0800, Andrew Morton wrote:
> Christoph Hellwig wrote:
> >
> > Rename the deprecated attribute to __deprecated to make it obvious
> > this is something special and to avoid namespace clashes.
> >
> > Mark more functionality deprecated:
> >
> > - sleep_on & friends
>
> Please do not make sleep_on() generate a warning. Unless you intend
> to do the same to lock_kernel().
>
> ext3 uses sleep_on(). It is perfectly safe.

Even if it's safe in that particular case, most code in the kernel runs
without BKL. This patch just makes the deprication of sleep_on
explicit.

> Weaning ext3 off lock_kernel()
> is a large, delicate and thus-far undesigned body of work. I've been
> working on other stuff and it is quite unlikely that ext3 locking will
> be redesigned in the 2.5 timeframe.

Then ext3 has to live with using depricated interfaces during 2.6,
what's the point?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/