Re: [PATCH] fix 2.4.x ieee1394

[Adrian Bunk]

On Sun, Dec 22, 2002 at 04:26:13AM -0700, Erik Andersen wrote:
> On Tue Dec 17, 2002 at 04:14:22PM +0000, linux-kernel wrote:
>...
> > --- a/drivers/ieee1394/Makefile	Tue Dec 17 12:33:07 2002
> > +++ b/drivers/ieee1394/Makefile	Tue Dec 17 12:33:07 2002
> > @@ -2,11 +2,8 @@
> >  # Makefile for the Linux IEEE 1394 implementation
> >  #
> >  
> > -O_TARGET := ieee1394drv.o
> > -
> 
> After this change, firewire doesn't build for me when adding
> 1394 stuff directly into the kernel, i.e.
> 
>     CONFIG_IEEE1394=y
>     CONFIG_IEEE1394_OHCI1394=m
>     CONFIG_IEEE1394_SBP2=m
>     CONFIG_IEEE1394_RAWIO=y
> 
> The top level kernel Makefile has:
>     DRIVERS-$(CONFIG_IEEE1394) += drivers/ieee1394/ieee1394drv.o
> but there is no longer a ieee1394drv.o target.  This patch fixes 
> the problem.
>...

When I try 2.4.21-pre2 with your patch and the IEEE 1394 options you 
mention in your mail _nothing_ gets built inside the drivers/ieee1394 
directory and the error message at the final linking is:

<--  snip  -->

...
        -o vmlinux
ld: cannot open drivers/ieee1394/ieee1394.o: No such file or directory
make: *** [vmlinux] Error 1

<--  snip  -->

How did you manage to get a kernel that actually compiles?

>  -Erik

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed