Re: missed inode->i_hash cleanup in prune_icache()

[Nikita Danilov]

Andrew Morton writes:
 > Nikita Danilov wrote:
 > > 

[...]

 > >                 struct inode *inode;
 > > 
 > >                 inode = list_entry(head->next, struct inode, i_list);
 > > -               list_del(&inode->i_list);
 > > +               list_del_init(&inode->i_list);
 > > 
 > >                 if (inode->i_data.nrpages)
 > >                         truncate_inode_pages(&inode->i_data, 0);
 > > 
 > 
 > That's i_list, not i_hash.
 > 
 > Yes, it's a bit sloppy to leave the i_list pointers dangling but
 > fs/inode.c:new_inode() will just overwrite i_list and all is well.
 > 
 > Could you please double-check or clarify the need for this change?

You are right, sorry. Probably I stared at these lists for too long or
too short a time. We are seeing garbage on sb->s_io in sync_sb_inodes(),
but probably this is some reiser4 problem after all.

Nikita.