Re: Modules with list

[Rusty Russell]

In message <[e-mail]> you write:
> Rusty Russell wrote:
> >In message <[e-mail]> you write:
> >> >This would only happen if someone says "rmmod --wait".
> 
> >As I realized last night after I wrote this, there is a bug in
> >module.c.  If O_NONBLOCK is specified, we shouldn't drop the module
> >sempaphore at all, for exactly this reason.  A bug I introduced while
> >"cleaning up" the "--wait" path.
> 
> >Sorry for the confusion.
> 
> 	Then if you do "rmmod --wait" on some module that is in use,
> every lsmod, insmod and rmmod will hang while attempting to acquire

Sorry, that's why I said "*If O_NONBLOCK* is specified" (ie. still
drop it for the --wait case).

Hope that clarifies,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.