RE: [BUG] [2.5.49] symbol_get doesn't work

[Wang, Stanley]

Sorry, my last patch would cause an incompatible type warning. The following
patch could do better.

diff -Naur -X dontdiff linux-2.5.49/include/linux/module.h
linux-2.5.49-bugfix/include/linux/module.h
--- linux-2.5.49/include/linux/module.h	2002-11-27 09:23:39.000000000 +0800
+++ linux-2.5.49-bugfix/include/linux/module.h	2002-11-27
09:23:54.000000000 +0800
@@ -86,7 +86,7 @@
 /* Get/put a kernel symbol (calls must be symmetric) */
 void *__symbol_get(const char *symbol);
 void *__symbol_get_gpl(const char *symbol);
-#define symbol_get(x) ((typeof(&x))(__symbol_get(#x)))
+#define symbol_get(t,x) ((typeof(t))(__symbol_get(#x)))
 
 /* For every exported symbol, place a struct in the __ksymtab section */
 #define EXPORT_SYMBOL(sym)				\

Thanks,
Stanley

> -----Original Message-----
> From: Wang, Stanley 
> Sent: 2002Äê11ÔÂ26ÈÕ 16:14
> To: '[e-mail]'
> Cc: '[e-mail]'
> Subject: [BUG] [2.5.49] symbol_get doesn't work
> 
> 
> Hello,
> I found the symbol_get()/symbol_put() didn't work on my 2.5.49 build.
> I think the root cause is a wrong macro definition. The 
> following patch could 
> fix this bug.
> 
> diff -Naur -X dontdiff linux-2.5.49/include/linux/module.h 
> linux-2.5.49-bugfix/include/linux/module.h
> --- linux-2.5.49/include/linux/module.h	2002-11-26 
> 16:06:36.000000000 +0800
> +++ linux-2.5.49-bugfix/include/linux/module.h	
> 2002-11-26 16:01:52.000000000 +0800
> @@ -86,7 +86,7 @@
>  /* Get/put a kernel symbol (calls must be symmetric) */
>  void *__symbol_get(const char *symbol);
>  void *__symbol_get_gpl(const char *symbol);
> -#define symbol_get(x) ((typeof(&x))(__symbol_get(#x)))
> +#define symbol_get(x) ((typeof(&x))(__symbol_get(x)))
>  
>  /* For every exported symbol, place a struct in the 
> __ksymtab section */
>  #define EXPORT_SYMBOL(sym)				\
> @@ -166,7 +166,7 @@
>  #ifdef CONFIG_MODULE_UNLOAD
>  
>  void __symbol_put(const char *symbol);
> -#define symbol_put(x) __symbol_put(#x)
> +#define symbol_put(x) __symbol_put(x)
>  void symbol_put_addr(void *addr);
>  
>  /* We only need protection against local interrupts. */
> 
> 
> Your Sincerely,
> Stanley Wang 
> 
> SW Engineer, Intel Corporation.
> Intel China Software Lab. 
> Tel: [phone] ext. 1171 
> iNet: 8-752-1171 
>  
> Opinions expressed are those of the author and do not 
> represent Intel Corporation
>