Re: Linux 2.5.49-ac1

[Adrian Bunk]

On Mon, Nov 25, 2002 at 06:52:49PM -0500, Alan Cox wrote:

>...
> Linux 2.5.49-ac1
>...
> o	Remove dead swsuspend defines			(Geert Uytterhoeven)
>...

This broke the compilation of kernel/sys.c:

<--  snip  -->

...
  gcc -Wp,-MD,kernel/.sys.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -p -Iarch/i386/mach-generic
-Iarch/i386/mach-defaults -nostdinc -iwithprefix include
-DKBUILD_BASENAME=sys -DKBUILD_MODNAME=sys   -c -o kernel/sys.o
kernel/sys.c
kernel/sys.c: In function `sys_reboot':
kernel/sys.c:473: `software_suspend_enabled' undeclared (first use in
this function)
kernel/sys.c:473: (Each undeclared identifier is reported only once
kernel/sys.c:473: for each function it appears in.)
kernel/sys.c:477: warning: implicit declaration of function
`software_suspend'
make[1]: *** [kernel/sys.o] Error 1

<--  snip  -->

The fix is simple:

--- linux-2.5.49-ac/kernel/sys.c.old	2002-11-26 14:57:54.000000000 +0100
+++ linux-2.5.49-ac/kernel/sys.c	2002-11-26 14:58:14.000000000 +0100
@@ -22,6 +22,7 @@
 #include <linux/security.h>
 #include <linux/dcookies.h>
 #include <linux/unistd.h>
+#include <linux/suspend.h>
 
 #include <asm/uaccess.h>
 #include <asm/io.h>

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed