Re: Patch?: module-init-tools/modprobe.c - use modules.dep

[Rusty Russell]

In message <[e-mail]> you write:
> 
> --xHFwDpU9dbj6ez1V
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> 
> 	The following patch changes modprobe in module-init-tools-0.8
> to use modules.dep.
> 
> 	Benefits:
> 
> 	- deletes a net of 594 lines of source code
> 
> 	- shrinks modprobe from 14kB to 10kB (stripped, dynamically linked),
> 	  which is useful for boot images
> 
> 	- should make modprobe as fast on systems with a lot of modules as
> 	  it was with the user level module loader,
> 
> 	- Restores the "include" command to the aliases file, which makes
> 	  it simpler to have separate files for automatically generated
> 	  aliases and user customizations.
> 
> 	- minor: eliminates ELF dependence from modprobe user level code

Hmm, I like it.  But I prefer to pull the depmod code into the source
too, to keep it all under one roof.

The ELF dependence will go back in eventually, but that's trivial.

Hmm, Adam, do you want to reverse positions and become
module-init-tools maintainer?  I'll send patches to you, instead of
vice versa.  I'll release a 0.8 with the patches I have so far, then
hand it over if you want.

Thoughts?
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.