[PATCH] ISDN multichannel crash

Herbert Xu (herbert@gondor.apana.org.au)
Sat, 16 Nov 2002 11:15:07 +1100


--tThc/1wpZn/ma/RB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

If you get the message

isdn_ppp_xmit: lp->ppp_slot -1

and your system crashes immediately afterwards, then this patch is for you.
The xmit_lock isn't released when this happens which leaves BH disabled.

The same fix is needed in 2.2 as well.

-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

--tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=p

Index: drivers/isdn/isdn_ppp.c =================================================================== RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/isdn/isdn_ppp.c,v retrieving revision 1.1.1.14 diff -u -r1.1.1.14 isdn_ppp.c --- drivers/isdn/isdn_ppp.c 3 Aug 2002 00:39:44 -0000 1.1.1.14 +++ drivers/isdn/isdn_ppp.c 16 Nov 2002 00:10:18 -0000 @@ -1147,7 +1147,7 @@ if (slot < 0 || slot > ISDN_MAX_CHANNELS) { printk(KERN_ERR "isdn_ppp_xmit: lp->ppp_slot %d\n", lp->ppp_slot); kfree_skb(skb); - return 0; + goto unlock; } ipt = ippp_table[slot]; lp->huptimer = 0;

--tThc/1wpZn/ma/RB-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/