Re: [PATCH] PARAM 2/4

Rusty Russell (rusty@rustcorp.com.au)
Sat, 16 Nov 2002 10:17:37 +1100

In message <3DD57A84.2070805@pobox.com> you write:
> 1) I note you ignored Matthew Wilcox's example of module_init being used
> in two different ways.

I didn't see it, sorry. Valid point.

> 2) "proper", converted-to-Rusty-style driver code is going to have
>
> MODULE_blah
> MODULE_foo
> MODULE_bar
> PARAM
>
> You think that looks good??

Hmm... OK, you've swayed me. I'll redo the patch.

> PARAM is ugly in drivers, and way too generic.

Well, we completely disagree on this point. If I was starting from
scratch, MODULE_AUTHOR would simply be AUTHOR(), etc.

But I've always opposed this kind of "neatening" as the ultimite in
stupidity, so consistency wins.

Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/