Re: [PATCH] early printk for x86

Jeff Garzik (jgarzik@pobox.com)
Thu, 14 Nov 2002 18:17:06 -0500


Looks pretty decent to me... minor comments:

* might be a good idea to match defaults with the defaults of the normal
serial console. IIRC that's 38400,N,8,1. which brings up a tangent,
57600 or 115200 is probably preferred these days, but that requires a
later patch to update serial console and early serial console to be faster

* VGA base might want to be a variable, though I have not convinced
myself that such is useful

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/