Re: Uninitialised timer in 2.5.47

[Hugh Dickins]

On Wed, 13 Nov 2002, Tomasz Torcz, BG wrote:
> 
> today I've booted 2.5.47 and got some unpleasant, oopslooking
> messages. It's looks like some debugging info.
> I'm including dmegs output, as it seems to contain enough info.
> If any more info is needed, I will happily provide it.
> ...
> Buffer I/O error on device loop(7,0), logical block 0
> Buffer I/O error on device loop(7,0), logical block 1
> Buffer I/O error on device loop(7,0), logical block 2
> (buffer errors till the end).

These messages are not related to the uninitialized timers you showed,
but to loop slightly broken in 2.5.47: Linus already took patch below.

--- 2.5.47/drivers/block/loop.c	Mon Nov 11 12:34:14 2002
+++ linux/drivers/block/loop.c	Mon Nov 11 15:44:33 2002
@@ -304,21 +304,16 @@
 {
 	struct lo_read_data cookie;
 	struct file *file;
-	int error;
+	int retval;
 
 	cookie.lo = lo;
 	cookie.data = kmap(bvec->bv_page) + bvec->bv_offset;
 	cookie.bsize = bsize;
-
-	/* umm, what does this lock actually try to protect? */
-	spin_lock_irq(&lo->lo_lock);
 	file = lo->lo_backing_file;
-	spin_unlock_irq(&lo->lo_lock);
-
-	error = file->f_op->sendfile(file, &pos, bvec->bv_len,
+	retval = file->f_op->sendfile(file, &pos, bvec->bv_len,
 			lo_read_actor, &cookie);
 	kunmap(bvec->bv_page);
-	return error;
+	return (retval < 0)? retval: 0;
 }
 
 static int