Re: 2.5-bk AT_GID clash
Nathan Scott (nathans@sgi.com)
Wed, 13 Nov 2002 18:34:11 +1100
On Wed, Nov 13, 2002 at 05:07:03AM +1100, Rusty Russell wrote:
> In message <1037122398.27014.43.camel@jen.americas.sgi.com> you write:
> >
> > But does everyone who wants to implement a module need to be exposed
> > to all the details of the elf header?
>
> Well, linux/module.h -> asm/module.h -> linux/elf.h. Although if you
> use #define instead of typedef you can break the last link. Feel free
> to send a patch to split it into moduleload.h or something, but I
> think it'll look tiny.
>
> But IMHO the nameclash needs to be fixed *anyway*, not hacked around,
> or someone else will run over it one day. AFAICT, changing
> fs/binfmt_elf.c and elf.h to AT_RGID is the simplest. Both should be
> mildly chastised for using a prefix like AT_ publically.
FWIW, we changed XFS earlier today - it will go to Linus in the
next batch of XFS mods. We're now using an XFS_AT_* convention
instead.
cheers.
--
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/