Re: iostats broken for devices with major number > DK_MAX_DISK (16)

Rick Lindsley (ricklind@us.ibm.com)
Tue, 12 Nov 2002 15:41:43 -0800


sorry for the intrusion. I noticed iostats didn't display statistics for
devices on Mylex RAID constrollers. Det statistics are completely
missing in /proc/stat. The reason seems to be an assumption that disks
have major numbers which are below 16
(http://lxr.linux.no/source/include/linux/kernel_stat.h#L15) which is
used by http://lxr.linux.no/source/fs/proc/proc_misc.c#L344.

Devices on Mylex-controllers have major number 48. Would it break
anything if DK_MAX_MAJOR if set higher (e.g. 64)?

AFAIK this goes for both 2.4 and the 2.5 series.

Which kernel did you observe it on?

In 2.4, yes, you're right. Without patches, there's a limit. Patches do
exist that remove those limits though.

In >= 2.5.47, no. They've been completely removed from /proc/stat and
appear in sysfs. And there are no major device number limits.

For various other flavors of 2.5 and assorted patches, the answer is
"well maybe, kind of" depending on where you got your 2.5 from and
what patches you may have applied on top of that.

Rick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/