Re: [BUG] Oopsen with pcmcia aironet wireless (2.5.47)

[Jean Tourrilhes]

On Mon, Nov 11, 2002 at 08:13:40PM -0800, Andrew Morton wrote:
> Andrew McGregor wrote:
> > 
> > I see lots of oopsen when I insert an Aironet PC4800 802.11 card.
> 
> They are debug warnings, not oopses.
> 
> > ...
> > Nov 12 15:40:39 localhost kernel: end_request: I/O error, dev hdb, sector 0
> > Nov 12 15:40:39 localhost last message repeated 3 times
> > Nov 12 15:40:39 localhost kernel: end_request: I/O error, dev hdc, sector 0
> > Nov 12 15:40:39 localhost last message repeated 2 times
> 
> hm.  IDE sick?
> 
> > Nov 12 15:40:39 localhost kernel: Debug: sleeping function called from
> > illegal context at include/asm/semaphore.h:145
> > Nov 12 15:40:39 localhost kernel: Call Trace:
> > Nov 12 15:40:39 localhost kernel:  [<e1a59215>] PC4500_readrid+0x55/0x160
> 
> airo_get_stats is called under the read_lock(&dev_base_lock); which was
> taken in dev_get_info.  So it may not call sleeping functions (ie:
> down_interruptible()).
> 
> It would appear that no netdevice->get_stats() method is allowed to sleep,
> which seems pretty dumb, IMVHO.

	Forwarded to airo maintainer.

	Javier :
	Most drivers collect stats based on Tx/Rx packets (they just
increment counters). Look at other driver for details. If you really
want to get stats out of the firmware, you may use the techinique I
used in orinoco for wireless stats, which is to use previous stats and
only call async the stat function.
	Have fun...

	Jean