Re: 2.5.46-mm2 - oops

[Andrew Morton]

Ed Tomlinson wrote:
> 
> On November 9, 2002 10:59 pm, Andrew Morton wrote:
> 
> > Of note in -mm2 is a patch from Chris Mason which teaches reiserfs to
> > use the mpage code for reads - it should show a nice reduction in CPU
> > load under reiserfs reads.
> 
> Booting into mm2 I get:
> 
> ...
> Unable to handle kernel NULL pointer dereference at virtual address 00000004
> 
> ...
> EIP is at mpage_readpages+0x47/0x140

whoops.  The ->readpages API was changed...

--- 25/fs/reiserfs/inode.c~reiserfs-readpages-fix	Sun Nov 10 10:44:28 2002
+++ 25-akpm/fs/reiserfs/inode.c	Sun Nov 10 10:44:39 2002
@@ -2081,7 +2081,7 @@ static int reiserfs_readpage (struct fil
 }
 
 static int
-reiserfs_readpages(struct address_space *mapping,
+reiserfs_readpages(struct file *file, struct address_space *mapping,
                struct list_head *pages, unsigned nr_pages)
 {
     return mpage_readpages(mapping, pages, nr_pages, reiserfs_get_block);

_