Re: [PATCH] Fix typo in sl82c105.c driver
Russell King (rmk@arm.linux.org.uk)
Fri, 8 Nov 2002 17:41:53 +0000
On Fri, Nov 08, 2002 at 05:38:29PM +0000, Alan Cox wrote:
> On Thu, 2002-11-07 at 02:55, Paul Mackerras wrote:
> > This patch fixes a minor typo in sl82c105.c which stops it from
> > compiling.
> >
> > Jens and/or Linus, please apply.
> >
> > Paul.
> >
> > diff -urN linux-2.5/drivers/ide/pci/sl82c105.c pmac-2.5/drivers/ide/pci/sl82c105.c
> > --- linux-2.5/drivers/ide/pci/sl82c105.c 2002-10-12 14:40:28.000000000 +1000
> > +++ pmac-2.5/drivers/ide/pci/sl82c105.c 2002-10-30 12:32:48.000000000 +1100
> > @@ -284,7 +284,7 @@
> >
> > static int __devinit sl82c105_init_one(struct pci_dev *dev, const struct pci_device_id *id)
> > {
> > - ide_pci_device_t *d = &slc82c105_chipsets[id->driver_data];
> > + ide_pci_device_t *d = &sl82c105_chipsets[id->driver_data];
> > if (dev->device != d->device)
> > BUG();
> > ide_setup_pci_device(dev, d);
>
> Looks good to me
It may look good. Shame that the DMA state machine gets screwed if you
have an ATAPI device on either channel, and needs code to reset it prior
to issuing a command.
Sorry, I've not been able to push the fixes forward yet. Its on my todo
list though.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/