Re: [PATCH] use seq_file for /proc/swaps

[Randy.Dunlap]

Hi Christoph,

I see you've already done this.  I was about to work on it
tonight (Monday night my time).  Oh well...thanks.

On Wed, 30 Oct 2002, Christoph Hellwig wrote:

| On Tue, Oct 29, 2002 at 10:12:59PM -0800, Randy.Dunlap wrote:
|
| > That meant that I had to duplicate create_seq_entry() or
| > export it.  For now I have duplicated it, and that would make
| > 3 copies of it in the kernel -- and that's bad IMO, so it would
| > need to be exported (but I didn't do that for now).
|
| Not sure whether that three lines of code are really worth exporting :)

Yeah, but I don't like duplicating code either.
More to find (or miss) whenever global changes are needed.

| > And there's the question of __init ordering: when will the __init
| > function mm/swap.c::swap_setup(), calling create_seq_entry(),
| > happen in relation to create_proc_entry() being ready to work?
|
| create_proc_entry() works as soon as kmalloc() works, i.e. it's fine
| for all initcalls.`

I was concerned about the ordering of procswaps_init() and
proc_root_init().  What happens if procswaps_init() is
called before proc_root_init() is called?
Or is there initcall ordering that prevents that?
If so, where is it?

-- 
~Randy