Re: ide-cd still borken for me in 2.5.45

[Jens Axboe]

On Fri, Nov 01 2002, Thomas Molina wrote:
> On Fri, 1 Nov 2002, Thomas Molina wrote:
> 
> > On Fri, 1 Nov 2002, Jens Axboe wrote:
> > 
> > > > hdc: irq timeout: status=0x90 {Busy}
> > > > hdc: irq timeout: error=0x01IllegalLengthIndication
> > > > hdc: drive not ready for command
> > > > hdc: ATAPI reset timed-out, status=0x80
> > > > ide1: reset: success
> > > 
> > > Interesting. Please send me a detailed list of your hardware, boot
> > > messages should suffice. Does 2.5.43 work correctly?
> > 
> > I get the same series of messages when booting 2.5.43.  I'll work my way 
> > back to find a version that works and report back when I find it.  
> > Following is the config file used to build this kernel:
> 
> Well that was quick.  2.5.42 works correctly.  The problems begin with 
> 2.5.43.

Ok, so Linus broke it :-)

Please boot with this patch, it looks like a command length screwup.

--- /opt/kernel/linux-2.5.45/drivers/ide/ide-cd.c	2002-11-01 11:31:53.000000000 +0100
+++ drivers/ide/ide-cd.c	2002-11-02 10:17:13.000000000 +0100
@@ -1498,6 +1498,8 @@
 	rq->flags &= ~REQ_FAILED;
 	len = rq->data_len;
 
+	printk("%s: starting %02x, len=%u\n", drive->name, rq->cmd[0], len);
+
 	/* Start sending the command to the drive. */
 	return cdrom_start_packet_command(drive, len, cdrom_do_pc_continuation);
 }

-- 
Jens Axboe