Re: and nicer too - Re: [PATCH] epoll more scalable than poll

Jamie Lokier (lk@tantalophile.demon.co.uk)
Wed, 30 Oct 2002 23:01:59 +0000


John Gardiner Myers wrote:
> I am uncomfortable with the way the epoll code adds its own set of
> notification hooks into the socket and pipe code. Much better would be
> to extend the existing set of notification hooks, like the aio poll code
> does.

Fwiw, I agree with the above (I'm having a think about it).

I also agree with criticisms that epoll should test and send an event
on registration, but only _if_ the test is cheap. Nothing to do with
correctness (I like the edge semantics as they are), but because
delivering one event is so infinitesimally low impact with epoll that
it's preferable to doing a single speculative read/write/whatever.

Regarding the effectiveness of the optimisation, I'd guess that quite
a lot of incoming connections do not come with initial data in the
short scheduling time after a SYN (unless it's on a LAN). I don't
know this for sure though.

-- Jamie

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/