Re: [RFC] generic_file_direct_IO() argument changes for AIO

[Andrew Morton]

Badari Pulavarty wrote:
> 
> Hi,
> 
> Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
> to generic_file_direct_IO() and all direct_IO() ops.
> 
> generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
>         loff_t offset, unsigned long nr_segs)
> 
> Instead of adding a new argument, I propose replace
> 
>         "struct file *file" argument with "struct kiocb *iocb"
> 
> One can get "filp" from iocb->ki_filp.
> 
> Any objections ?
> 

OK by me.

BTW, while you're poking around in there could you please rename
generic_direct_IO() to blockdev_direct_IO() and move
generic_file_direct_IO() back into filemap.c?