Re: [2.5 patch] allow only one Toshiba Type-O IR Port driver in the kernel

[Jean Tourrilhes]

On Tue, Oct 29, 2002 at 04:26:50PM +0100, Adrian Bunk wrote:
> On Mon, 21 Oct 2002, Jean Tourrilhes wrote:
> 
> > 	Adrian,
> 
> Hi Jean,
> 
> > 	Thanks very much for the report. I personally uses modules,
> > and I would prefer the ability to compile both modules, so that people
> > can try both without having to recompile their kernel.
> 
> notice that my patch doesn't disallow to build both drivers as modules.
> 
> > 	I think a much better patch (and simpler in the long term)
> > would be to just rename 'toshoboe_init' to 'donauboe_init' (plus the
> > few other offending function). This is a case where the name doesn't
> > really matter.
> > 	What do you think ?
> 
> That's an alternate solution that should also fix the compile problem.
> 
> But as stated above my patch doesn't affect the case when both drivers are
> modular which is usually the desired setup when you want to switch between
> the two drivers.

	I personally prefer to make the driver code cleaner rather
than making the config/Makefile rules more complex. I believe that in
the long run, it always pay to keep things simple.
	But, I'm not religious about it.

> cu
> Adrian

	How do we proceed ? Do you want to send patches yourself
directly, or do you want to wait until I send my next IrDA update ?
	Regards,

	Jean