Re: [PATCH] unified SysV and Posix mqueues as FS

Manfred Spraul (manfred@colorfullife.com)
Mon, 28 Oct 2002 22:43:26 +0100


Peter Waechtler wrote:

>>For the locking stuff, the patch should probably depend on the sysv rcu
>>patch, it cleans up locking a bit.
>>
>>
>>
>
>Well, I am a victim of "information hiding" ;-)
>
>
That's not information hiding - there were 3 different locking
implementations: first one with a per-queue spinlock that didn't support
growing the number of queues at runtime, then one with a global rw lock
and a per-queue spinlock, and the simple, global spinlock version that's
part of 2.3.x-2.5.4x.

>msq_lock(id) does not lock a queue, it locks/unlocks the whole array.
>Forget my post about a deadlock in ipc_addid()
>
>
Which deadlock did you see? With the RCU ipc patch [part of 2.5.44-mm6],
msg_lock again locks the queue, not the whole array. Calls to
ipc_addid() with the msq spinlock aquired are not permitted.

--
    Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/