Re: [PATCH] unified SysV and Posix mqueues as FS

[Peter Waechtler]

Manfred Spraul schrieb:
> 
>  > - notification not tested
>  > - still linear search in queues
> 
> Is that a problem? Receive does one linear search of the queued
> messages, send does one linear search of the waiting receivers. Both
> lists should be short.
> 

Yes, they _should_ but don't have to be.
It only matters if you ask for specific priority/type of message.

> Could you split your patch into the functional changes and cleanup?
> (const, size_t, you move a few definitions around, whitespace cleanups)
> 
> I don't like the deep integration of the mqueues into the sysv code - is
> that really needed?
> For example, you add the mqueue messages into the sysv array, and then
> add lots of code to separate both again - IPC_RMID cannot remove posix
> queues, etc.
> 
> Have you tried to separate both further? Create a ramfs like filesystem,
> store msg_queue in the inode structure?
> The ids array is only for sysv, only the actual message handling is
> shared between sysv msg and posix mqueues
> 

I plan to separate the interfaces and just share the message stuff.
But time was getting short. :)