Re: [PATCH]: linux-2.5.44uc1 (MMU-less support)

[Miles Bader]

Sam Ravnborg <[e-mail]>:
>  +arch/$(ARCH)/kernel/asm-offsets.s: include/asm include/linux/version.h \
>  +                                  include/config/MARKER
>  +
>  +include/asm-$(ARCH)/asm-offsets.h.tmp: arch/$(ARCH)/kernel/asm-offsets.s
>  +       @$(generate-asm-offsets.h) < $< > $@
>  +
>  +include/asm-$(ARCH)/asm-offsets.h: include/asm-$(ARCH)/asm-offsets.h.tmp
>  +       @echo -n '  Generating $@'
>  +       @$(update-if-changed)
>
>  Combine it like this instead:
>
>  include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \
>                                     include/asm include/linux/version.h \
>                                     include/config/MARKER
>          @echo -n '  Generating $@'
>          @$(generate-asm-offsets.h) < $< > $@
>          @$(update-if-changed)
>
>  Thats more readable, and follow te normal way of doing it.

It may be more readable, but I don't think you can say it's the `normal way
of doing it,' at least in linux -- almost all the arch Makefiles have code
pretty much identical to Greg's (presumably all derived from a single
original source).

Perhaps they should all be changed.

-Miles

[the threading info on this msg is wrong because MARC's `Download message
 RAW' option doesn't provide the message headers; quite annoying, that...]
-- 
"1971 pickup truck; will trade for guns"