Re: [PATCH] EVMS core 1/4: evms.c

[Ingo Oeser]

On Fri, Oct 04, 2002 at 03:56:39PM +0100, Christoph Hellwig wrote:
> > + * allocates and zeros an evms_logical_node structure.
> > + *
> > + * returns: 0 if sucessful
> > + *          -ENOMEM if unsuccessful
> > + **/
> > +int
> > +evms_cs_allocate_logical_node(struct evms_logical_node **pp)
> > +{
> > +	*pp = kmalloc(sizeof (struct evms_logical_node), GFP_KERNEL);
> > +	if (*pp == NULL) {
> > +		return -ENOMEM;
> > +	}
> > +	memset(*pp, 0, sizeof (struct evms_logical_node));
> > +	return 0;
> 
> A helper for kmalloc + memset looks rather pointles..
 
This looks, like they want to slabify it later. But a define
might be better here, indeed.

Regards

Ingo Oeser
-- 
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth