Re: [PATCH] 2.5.40: lkcd (4/9): additional kernel symbols

[Andi Kleen]

"Matt D. Robinson" <[e-mail]> writes:

> diff -urN -X /home/bharata/dontdiff linux-2.5.40/arch/i386/kernel/i386_ksyms.c linux-2.5.40+lkcd/arch/i386/kernel/i386_ksyms.c
> --- linux-2.5.40/arch/i386/kernel/i386_ksyms.c	Tue Oct  1 12:36:59 2002
> +#if defined(CONFIG_X86) || defined(CONFIG_ALPHA)
> +EXPORT_SYMBOL(page_is_ram);
> +#endif

This ifdef in i386_ksyms.c doesn't make much sense...

> +#ifdef CONFIG_SMP
> +extern irq_desc_t irq_desc[];
> +extern unsigned long irq_affinity[];
> +EXPORT_SYMBOL(irq_affinity);
> +EXPORT_SYMBOL(irq_desc);
> +extern void dump_send_ipi(void);
> +EXPORT_SYMBOL(dump_send_ipi);
> +extern int (*dump_ipi_function_ptr)(struct pt_regs *);
> +EXPORT_SYMBOL(dump_ipi_function_ptr);
> +extern void (*dump_trace_ptr)(struct pt_regs *);
> +EXPORT_SYMBOL(dump_trace_ptr);
> +extern void show_this_cpu_state(int, struct pt_regs *, struct task_struct *);
> +EXPORT_SYMBOL(show_this_cpu_state);

Before adding all these ugly declarations I would just declare the file where
whey are exported from as 'x-obj' and put them directly to where the 
functions live.

-Andi