Re: [BK PATCH] pcibios_* removals for 2.5.40

[Greg KH]

On Fri, Oct 04, 2002 at 05:40:07PM -0400, Jeff Garzik wrote:
> >diff -Nru a/drivers/char/rocket.c b/drivers/char/rocket.c
> >--- a/drivers/char/rocket.c	Fri Oct  4 13:47:29 2002
> >+++ b/drivers/char/rocket.c	Fri Oct  4 13:47:29 2002
> >@@ -1993,7 +1993,7 @@
> > 			isa_boards_found++;
> > 	}
> > #ifdef CONFIG_PCI
> >-	if (pcibios_present()) {
> >+	if (pci_present()) {
> > 		if(isa_boards_found < NUM_BOARDS)
> > 			pci_boards_found = init_PCI(isa_boards_found);
> > 	} else {
> 
> can be greatly simplified -- just simply all the code in the ifdef to 
> "if (isa_boards_found...) ...init_PCI..."

Heh, again, this driver needs some major work in regards to PCI
cleanups, it's quite old.  It can probably be converted over to use the
drivers/serial core too.

thanks,

greg k-h