Re: [Evms-devel] Re: [PATCH] EVMS core 1/4: evms.c

[Mark Peloquin]

On Friday 04 October 2002 09:56, Christoph Hellwig wrote:

> > +/**
> > + * find_next_volume - locates first or next logical volume
> > + * @lv:            current logical volume
> > + *
> > + * returns the next logical volume or NULL
> > + **/
>
> All user of this look like they better used list_for_each?
>
> > +
> > +/**
> > + * find_next_volume_safe - locates first or next logical volume (safe
> > for removes) + * @next_lv:      ptr to next logical volume
> > + *
> > + * returns the next logical volume or NULL
> > + **/
>
> Dito with list_for_each_safe

This was done to abstract the storage/lookup
method. Currently with only 256 minors per major
a simply kernel list is adequate, however once
the kernel goes to 20-bit minors a list will not
be sufficient.