Re: [Evms-devel] Re: [PATCH] EVMS core 4/4: evms_biosplit.h

[Christoph Hellwig]

On Thu, Oct 03, 2002 at 03:36:24PM -0500, Mark Peloquin wrote:
> 
> On 10/03/2002 at 10:05 AM, Christoph Hellwig wrote:
> 
> >> +static mempool_t *my_bio_split_pool, *my_bio_pool;
> >> +static kmem_cache_t *my_bio_split_slab, *my_bio_pool_slab;
> 
> > Umm, static variables in header files?
> 
> Yupp, that wasn't accidental.
> 
> Based on the conclusions mutually agreed on in the OLS
> BOF on bio splitting, it was decided that each driver
> having the need to split bios *should* have their own
> private bio pools to use exclusively for this purpose.
> Thus any plugin that includes this header gets their
> own private copies of these variables.

Having variables and (non-inline) functions is very bad style and a
perfect method for the obsfucated C contest.  Just let every module
that needs bio-splitting declare it's own variables.