Re: [PATCH] cli()/sti() fix for drivers/net/depca.c
Francois Romieu (romieu@cogenit.fr)
Thu, 3 Oct 2002 18:40:41 +0200
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> :
[...]
> > depca_rx() looks strange:
> > buf = skb_put(skb, len);
> > [...]
> > netif_rx(skb);
> > [...]
> > if (buf[0] & ...)
>
> I'd say this network stuff is a bit cryptic for untrained eye :-)
> What's strange with that code?
One shouldn't assume the buffer is available once it was passed to
netif_rx().
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/