Re: [PATCH] pcnet32 cable status check

Jeff Garzik (jgarzik@pobox.com)
Mon, 30 Sep 2002 16:21:50 -0400


Comments:

It looks good as a starting point :)

I just added mii_check_media() to drivers/net/mii.c. It's in the latest
2.5.x snapshot,
ftp://ftp.kernel.org/pub/linux/kernel/v2.5/snapshots/patch-2.5.39-bk2.bz2

and is in Marcelo's inbox as well. For simple implementations (and I
think pcnet32 qualifies), the timer should not need to do anything
beyond calling mii_check_media(). One important feature of this is use
of the standard netif_carrier_{off,on} to indicate link to the system.
netif_carrier_xxx also means you don't need lp->link...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/