Re: [PATCH] 2.4.20 Direct IO patch for NFS. (Note: a trivial API change...)

[Matthew Wilcox]

On Mon, Sep 30, 2002 at 08:34:04PM +0200, Trond Myklebust wrote:
> diff -u --recursive --new-file linux-2.4.20-pre8/fs/block_dev.c linux-2.4.20-directio/fs/block_dev.c
> --- linux-2.4.20-pre8/fs/block_dev.c	Sun May 12 02:26:03 2002
> +++ linux-2.4.20-directio/fs/block_dev.c	Mon Sep 30 18:24:45 2002
> @@ -131,8 +131,9 @@
>  	return 0;
>  }
>  
> -static int blkdev_direct_IO(int rw, struct inode * inode, struct kiobuf * iobuf, unsigned long blocknr, int blocksize)
> +static int blkdev_direct_IO(int rw, struct file * filp, struct kiobuf * iobuf, unsigned long blocknr, int blocksize)
>  {
> +	struct inode * inode = filp->f_dentry->d_inode->i_mapping->host;
>  	return generic_direct_IO(rw, inode, iobuf, blocknr, blocksize, blkdev_get_block);
>  }
>  

isn't that two dereferences more than necessary for a local filesystem?

-- 
Revolutions do not require corporate support.