Re: [patch] fix parport_serial / serial link order (for 2.4.20-pre8)

Russell King (rmk@arm.linux.org.uk)
Mon, 30 Sep 2002 10:49:28 +0100


On Mon, Sep 30, 2002 at 10:40:12AM +0100, Tim Waugh wrote:
> On Thu, Sep 26, 2002 at 10:05:16PM +0200, Marek Michalkiewicz wrote:
> > below is a patch that moves parport_serial.c from drivers/parport/
> > to drivers/char/ - this fixes the wrong link order when the drivers
> > are compiled into the kernel.
>
> What was wrong with the original, much smaller patch that you sent me
> previously (below)?
>
> I'm happy to accept whichever patch is the better.

Other than it's a gross hack rather than a fix. However, for 2.4, I
think this is probably the best solution without creating a risk of
other init ordering problems. Ed, any comments?

In 2.5, its easier to solve; we just need to make sure serial is
initialised before parport. This is easy, since serial now has its
own drivers/serial subdirectory.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/