Re: [PATCH] ALSA update [6/10] - 2002/07/20

David S. Miller (davem@redhat.com)
Sun, 29 Sep 2002 17:53:11 -0700 (PDT)


From: Jaroslav Kysela <perex@suse.cz>
Date: Sun, 29 Sep 2002 22:34:51 +0200 (CEST)

- if (hwdev == NULL || ((u32)hwdev->dma_mask != 0xffffffff))
+ if (hwdev == NULL || (u32)hwdev->dma_mask <= 0x00ffffff)
gfp |= GFP_DMA;

So alan, why is this really broken?

EISA/ISA DMA is defined as using a hwdev of NULL or requiring
<16MB address, he is preserving GFP_DMA in those cases.

The only problem I have with the patch is that it probably isn't
that hard to let the page allocator take some MASK arg (defaults
to all 1's) to implement this in 2.5.x
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/