Re: show_stack()/show_trace() prototypes

Paul Mackerras (paulus@au1.ibm.com)
Sun, 29 Sep 2002 10:18:48 +1000 (EST)


David Mosberger writes:

> Ingo, the ksymoops patch adds these to linux/sched.h:
>
> extern void show_trace(unsigned long *stack);
> extern void show_stack(unsigned long *stack);
>
> This is not good.

I agree. It is unnecessary to have these declarations in
linux/sched.h since these functions are only called from arch code.
So I would also vote for having the declarations arch-specific.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/