Re: [PATCH] Put modules into linear mapping

[Andi Kleen]

On Fri, Sep 27, 2002 at 05:55:13PM +0200, Roman Zippel wrote:
> Hi,
> 
> On 27 Sep 2002, Andi Kleen wrote:
> 
> > > Why is i386 only? This is generic code and other archs will benefit from
> > > it as well (or at least it won't hurt).
> >
> > Because some arcitectures have a different module_map() (e.g. x86-64 or
> > sparc64)
> 
> As I already said in the last mail, these functions look like vmalloc
> reimplementations.

No, they aren't. x86-64 uses it because modules need to be in 32bit
range from the main kernel and vmalloc is in a different area. I suspect
it is the same on sparc64.

> > and > order 0 is the only case that is interesting for alloc_exact.
> > GFP_DMA is not needed here, and GFP_HIGHUSER neither supports > order 0
> > properly (because of kmap)
> 
> If it's supposed to be a generic function, it makes sense, otherwise we
> could just put it into module.c.

Ok, I will change it.

-Andi