Re: [linux-usb-devel] [RFC] consolidate /sbin/hotplug call for pci and usb
Greg KH (greg@kroah.com)
Wed, 25 Sep 2002 17:25:54 -0700
On Wed, Sep 25, 2002 at 05:11:57PM -0700, David Brownell wrote:
>
> >+ /* stuff we want to pass to /sbin/hotplug */
> >+ envp[i++] = scratch;
> >+ scratch += sprintf (scratch, "PCI_CLASS=%04X", pdev->class) + 1;
> >+
> >+ envp[i++] = scratch;
> >+ scratch += sprintf (scratch, "PCI_ID=%04X:%04X",
> >+ pdev->vendor, pdev->device) + 1;
>
> And so forth. Use "snprintf" and prevent overrunning those buffers...
Doh, will do.
I also found the unload USB module problem. The driver core was calling
hotplug after the device was already removed. Made it a bit difficult
to be able to describe the device that way :)
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/