Re: [PATCH]: 2.5.38uc1 (MMU-less support)

Greg KH (greg@kroah.com)
Wed, 25 Sep 2002 08:43:00 -0700


On Wed, Sep 25, 2002 at 03:19:43PM +0100, Matthew Wilcox wrote:
> * You're defining CONFIG_* variables in the .c file. I don't know whether
> this is something we're still trying to avoid doing ... Greg, you seem
> to be CodingStyle enforcer, what's the word?

I haven't seen that used very much, but I would not recommend it. Why
not just move it to the Config.in file? And if they are always set,
just remove them.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/