Re: [PATCH] Module rewrite 2/20: bigrefs

[Neil Brown]

On Wednesday September 25, [e-mail] wrote:
> +static inline void bigref_init(struct bigref *ref, int value)
> +{
> +	unsigned int i;
> +	atomic_set(&ref->ref[0].counter, value);
> +	for (i = 1; i < NR_CPUS; i++)
-----------------^
> +		atomic_set(&ref->ref[i].counter, 0);
> +	ref->waiter = NULL; /* To trap bugs */
> +}

Should this be '0', or should there be a comment explaining why it
one?

NeilBrown