Re: [PATCH][RFC] oprofile 2.5.38 patch

[John Levon]

On Tue, Sep 24, 2002 at 02:43:47PM +0200, Andi Kleen wrote:

> wouldn't an on stack buffer do nicely to format a single number ? 

Yes, this was a lazy adaption of other code. Will fix.

> it doesn't length limit count before passing to kmalloc - hole.
> Also has overflow bugs (consider someone passing 0xffffffff-1). 

Thanks.

> The sys_lookup_dcookie call looks like a security hole to me. After

I'll make it CAP_SYS_ADMIN ?

> Adding a list_head to task_struct looks quite ugly to me. Is there
> surely no better way ? e.g. you could just put it in a file private
> structure and the daemon keeps the file open.

Well, if I'm going to "hard code" the unregister I can just remove the
registration and let the oprofile code call dcookie_init/exit on event
buffer open/release.

thanks
john