Re: ReiserFS buglet

[Oleg Drokin]

Hello!

On Tue, Sep 24, 2002 at 09:24:55AM +0200, Jakob Oestergaard wrote:

> In linux-2.4.19, I found the following:
> fs/reiserfs/super.c:707
>  s->s_blocksize = sb_blocksize(rs);
>  s->s_blocksize_bits = 0;
>  while ((1 << s->s_blocksize_bits) != s->s_blocksize)
>      s->s_blocksize_bits ++;
> What happens if there's a bit-flip on the disk so that s->s_blocksize is
> not a power of two ?

FS will refuse to mount. Or kernel will panic (depends on some stuff).
If s->s_blocksize is zeroed, kernel will hang, as you correctly noticed.

> I would suggest replacing the '!=' with a '<' in the while loop and
> adding a sanity check afterwards.

What if overheated CPU will cause a bitflip exactly after such checks?
You cannot protect against broken hardware. Such problems should be
fixed by fsck.

> As I see it, the ReiserFS journal has the same problems as jbd wrt. to
> atomicity of write operations of indexes.  Please see my recent mail
> about the jbd problems.

journal header in reiserfs only occupies first 20 bytes of the block,
since this fells within 1st 512 bytes hardware sector, it will be written
atomically, I presume.

Bye,
    Oleg