Re: IDE janitoring comments

Benjamin Herrenschmidt (benh@kernel.crashing.org)
Mon, 23 Sep 2002 09:29:42 +0200


>we have one special problem on m68k, on some machines the IDE
>bus is byteswapped (unrelated to cpu endianness). For historical
>and performance reasons data to the HD is by default read and
>written in this "wrong" order (thus the bswap/swapdata option)
>and special fixup code is used in ide_fix_driveid (see
>M68K_IDE_SWAPW). However data returned by IDE_DRIVE_CMD is not
>treated in any way, so that eg WIN_SMART data end up in the
>wrong order on those machines and this is something I would
>like to fix properly.
>I figure I would define ata_*_{control,data} to handle special
>data resp raw HD data and modify ide_handler_parser to return
>specialised interrupt handlers or set some additional flag.
>
>Any thoughts?

You just need to provide your own ide-ops doing the right
thing, I don't think you need to touch ata_*_data if you
properly implement "s" ops {in,out}s{b,w,l} for your hwif.

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/