Re: DAC960 in 2.5.38, with new changes

[Daniel Phillips]

On Monday 23 September 2002 21:19, David Mosberger wrote:
> Hi Dave,
> 
> >>>>> On Mon, 23 Sep 2002 12:04:00 -0700, Dave Olien <[e-mail]> said:
> 
>   Dave> #ifdef __ia64__
>   Dave> -  writeq(Virtual_to_Bus64(CommandMailbox),
>   Dave> +  writeq(CommandMailboxDMA,
>   Dave> ControllerBaseAddress + DAC960_LP_CommandMailboxBusAddressOffset);
>   Dave> #else
>   Dave> -  writel(Virtual_to_Bus32(CommandMailbox),
>   Dave> +  writel(CommandMailboxDMA,
>   Dave> ControllerBaseAddress + DAC960_LP_CommandMailboxBusAddressOffset);
>   Dave> #endif
> 
> This looks like a porting-nightmare in the making.  There's got to be a
> better way to determine whether you need a writeq() vs. a writel().

Even if an #ifdef is necessary here (and we are in trouble if it is) it
should not trigger on __ia64__, it should trigger on the size of (long).

-- 
Daniel