Re: [PATCH] de-xchg fork.c

[Robert Love]

On Mon, 2002-09-23 at 14:31, Ingo Molnar wrote:

> the attached patch (against BK-curr) fixes all xchg()'s and a preemption
> bug.

Thanks, Ingo.

> --- linux/kernel/fork.c.orig	Mon Sep 23 20:28:36 2002
> +++ linux/kernel/fork.c	Mon Sep 23 20:30:02 2002
> @@ -64,11 +64,12 @@
>  	} else {
>  		int cpu = smp_processor_id();
>  
> -		tsk = xchg(task_cache + cpu, tsk);
> +		tsk = task_cache[cpu];
>  		if (tsk) {
>  			free_thread_info(tsk->thread_info);
>  			kmem_cache_free(task_struct_cachep,tsk);
>  		}
> +		task_cache[cpu] = current;
>  	}
>  }

I think you need get/put_cpu() here, too?

	Robert Love