Re: my review of the Device Driver Hardening Design Spec

[Andre Hedrick]

#ifndef __MYDRVR_H__
#define __MYDRVR_H__

#define MYDRVR_IOCTL_MAGIC 'm'

#define MYDRVR_IOCTL_RCV    _IO(MYDRVR_IOCTL_MAGIC, 0)

typedef struct _MYDRVR_CONTEXT {

   unsigned long cRCV;  /* number of RCV ioctls made */
   unsigned long cDeviceOpen; /* device open count */

} MYDRVR_CONTEXT, *PMYDRVR_CONTEXT;

#define ZEROMEMORY(pAddr, cbSize)               \
{                                               \
    int i;                                      \
    char *d = (char *)(pAddr);                  \
    for ( i = 0; i < (cbSize); i++, *d++ = 0 ); \
}

#endif /* __MYDRVR_H__ */

SHEESH, COULD THEY LEARN THERE IS MORE TO LIFE THAN ALL CAPS??

Sweet, that is "stick ugly"!

stick ugly : beating with a stick and it can not made any uglier than it
		is presently.

Andre Hedrick
LAD Storage Consulting Group

On Sat, 21 Sep 2002, Greg KH wrote:

> On Sat, Sep 21, 2002 at 11:52:19PM +0200, Francois Romieu wrote:
> > [Cc list trimmed]
> > 
> > Greg KH <[e-mail]> :
> > [...]
> > > Oh, there's lots of code:
> > > 	A "hardened" binary kernel driver:
> > > 		http://unc.dl.sourceforge.net/sourceforge/hardeneddrivers/sampledriver-0.1-1.i386.rpm
> > > 	(um people, why a binary?  Where's the source for this?)
> > 
> > In the cvs. See:
> > http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/hardeneddrivers/sample_driver/src/
> 
> Thanks for pointing this out, I missed it.
> 
> Hm, if this is the code that the CG group is proposing for reliable
> drivers, we are all in trouble.  See:
> 	http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/hardeneddrivers/sample_driver/src/sampledriver.h?rev=1.1.1.1
> 
> as a very small example of what not to do :)
> 
> I'd be glad to provide concrete criticism of the other files in this
> directory, if I thought people would actually change their programming
> style to follow what their own spec says to do...
> 
> {sigh}
> 
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/hardeneddrivers/sample_driver/src/sampledriver_init.c?rev=1.1.1.1
> contains so many examples of bad style, and real bugs...
> 
> greg k-h
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [e-mail]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>