Re: [PATCH] In-kernel module loader 5/7

[J.A. Magallon]

On 2002.09.18 Rusty Russell wrote:
>Name: Every module needs module_init
>Author: Rusty Russell
>Status: Trivial
>
>D: Every module needs a module_init now, so insert a trivial one where
>D: needed.  This is not exhaustive.
>
>diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .17783-2.5.35-modbase-try-i386.pre/lib/zlib_deflate/deflate_syms.c .17783-2.5.35-modbase-try-i386/lib/zlib_deflate/deflate_syms.c
>--- .17783-2.5.35-modbase-try-i386.pre/lib/zlib_deflate/deflate_syms.c	2002-02-20 17:56:17.000000000 +1100
>+++ .17783-2.5.35-modbase-try-i386/lib/zlib_deflate/deflate_syms.c	2002-09-18 11:45:27.000000000 +1000
>@@ -19,3 +19,9 @@ EXPORT_SYMBOL(zlib_deflateReset);
> EXPORT_SYMBOL(zlib_deflateCopy);
> EXPORT_SYMBOL(zlib_deflateParams);
> MODULE_LICENSE("GPL");
>+
>+static int init(void)
>+{
>+	return 0;
>+}
>+module_init(init);

Would not be worthy to do something like

#define MODULE_INIT_DEFAULT \
static int init(void) { return o;} \
module_init(init)
...

so you just can add:

MODULE_INIT_DEFAULT;
MODULE_EXIT_DEFAULT;

-- 
J.A. Magallon <[e-mail]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.0 (Cooker) for i586
Linux 2.4.20-pre7-jam1 (gcc 3.2 (Mandrake Linux 9.0 3.2-1mdk))